Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply suggested style changes to C# code #18

Merged
merged 20 commits into from
Nov 27, 2023
Merged

Apply suggested style changes to C# code #18

merged 20 commits into from
Nov 27, 2023

Conversation

wilyle
Copy link
Contributor

@wilyle wilyle commented Nov 20, 2023

This PR applies suggested style changes to C# code from the official .NET tooling. This also adds a step to the .NET CI workflow to perform these checks

Also makes a few documentation changes related to one of the CA2254 changes since there's less information in the exception now. That info is still being logged though and now the exception is documented better, so I don't think we need that info in the exception itself

ashbeitz
ashbeitz previously approved these changes Nov 20, 2023
Copy link

@ashbeitz ashbeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

devkelley
devkelley previously approved these changes Nov 21, 2023
Copy link

@ashbeitz ashbeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments.

Copy link

@ashbeitz ashbeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@wilyle wilyle merged commit 91d6a89 into main Nov 27, 2023
10 checks passed
@wilyle wilyle deleted the wilyle/style branch November 27, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants